[Webkit-unassigned] [Bug 58416] [GTK] Implement UI client in minibrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58416





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-04-14 01:57:41 PST ---
(In reply to comment #2)
> (From update of attachment 89348 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89348&action=review
> 
> > Tools/MiniBrowser/gtk/BrowserWindow.c:52
> > +static void browserWindowUiClientInit(BrowserWindow*);
> 
> Should be browserWindowUIClientInit

Ok.

> > Tools/MiniBrowser/gtk/BrowserWindow.c:390
> > +{
> > +    WKViewRef webView = WKViewCreate(WKPageGetContext(page), 0);
> > +    BrowserWindow* window = BROWSER_WINDOW(browserWindowNew(webView));
> > +    return WKViewGetPage(window->webView);
> > +}
> 
> Maybe browser_window_new should take in the features dictionary to set the size, etc.

We could use the features to set up the window before showing it, but I'm not sure the window should take the features. We can leave this for future patches, other ports ignore this for now too.

> > Tools/MiniBrowser/gtk/BrowserWindow.c:426
> > +    WKPageUIClient uiClient = {
> > +        0,      /* version */
> > +        window, /* clientInfo */
> > +        createNewPage,
> > +        showPage,
> > +        closePage,
> > +        runJavaScriptAlert,
> > +        0,  /* runJavaScriptConfirm */
> > +        0,  /* runJavaScriptPrompt */
> > +        0,  /* setStatusText */
> > +        0,  /* mouseDidMoveOverElement */
> > +        0,  /* missingPluginButtonClicked */
> > +        0,  /* didNotHandleKeyEvent */
> > +        0,  /* toolbarsAreVisible */
> > +        0,  /* setToolbarsAreVisible */
> > +        0,  /* menuBarIsVisible */
> > +        0,  /* setMenuBarIsVisible */
> 
> Please line up the comments on these lines. :)

Sure.

> > Tools/MiniBrowser/gtk/main.c:43
> > +static void loadUri(const gchar *uri)
> 
> Should be loadURI.

Ok.

> > Tools/MiniBrowser/gtk/main.c:57
> > +    { G_OPTION_REMAINING, 0, 0, G_OPTION_ARG_FILENAME_ARRAY, &uriArguments, 0, "[URL…]" },
> 
> Are there some extra characters at the end of "[URL…]"

Looks like a bug in review tool, it's utf-8 text, try opening the attachment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.