[Webkit-unassigned] [Bug 58416] [GTK] Implement UI client in minibrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58416





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-04-13 08:10:32 PST ---
(From update of attachment 89348)
View in context: https://bugs.webkit.org/attachment.cgi?id=89348&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:52
> +static void browserWindowUiClientInit(BrowserWindow*);

Should be browserWindowUIClientInit

> Tools/MiniBrowser/gtk/BrowserWindow.c:390
> +{
> +    WKViewRef webView = WKViewCreate(WKPageGetContext(page), 0);
> +    BrowserWindow* window = BROWSER_WINDOW(browserWindowNew(webView));
> +    return WKViewGetPage(window->webView);
> +}

Maybe browser_window_new should take in the features dictionary to set the size, etc.

> Tools/MiniBrowser/gtk/BrowserWindow.c:426
> +    WKPageUIClient uiClient = {
> +        0,      /* version */
> +        window, /* clientInfo */
> +        createNewPage,
> +        showPage,
> +        closePage,
> +        runJavaScriptAlert,
> +        0,  /* runJavaScriptConfirm */
> +        0,  /* runJavaScriptPrompt */
> +        0,  /* setStatusText */
> +        0,  /* mouseDidMoveOverElement */
> +        0,  /* missingPluginButtonClicked */
> +        0,  /* didNotHandleKeyEvent */
> +        0,  /* toolbarsAreVisible */
> +        0,  /* setToolbarsAreVisible */
> +        0,  /* menuBarIsVisible */
> +        0,  /* setMenuBarIsVisible */

Please line up the comments on these lines. :)

> Tools/MiniBrowser/gtk/main.c:43
> +static void loadUri(const gchar *uri)

Should be loadURI.

> Tools/MiniBrowser/gtk/main.c:57
> +    { G_OPTION_REMAINING, 0, 0, G_OPTION_ARG_FILENAME_ARRAY, &uriArguments, 0, "[URL…]" },

Are there some extra characters at the end of "[URL…]"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.