[Webkit-unassigned] [Bug 57068] [GTK] [WebKit2] Implement a basic WebKitTestRunner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57068





--- Comment #14 from Martin Robinson <mrobinson at webkit.org>  2011-04-12 17:42:33 PST ---
(In reply to comment #10)
> (From update of attachment 89039 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89039&action=review

Thanks for your comments!

> > Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp:-124
> > -bool WebPage::platformCanHandleRequest(const WebCore::ResourceRequest&)
> > -{
> > -    // FIXME: Implement
> > -    return true;
> > -}
> > -
> 
> Why we should remove this function?

Sorry, this snuck in from a previous version of the patch. I've removed this change.

> 
> > Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:79
> > +    gint depth;
> > +    gdk_window_get_geometry(gtk_widget_get_window(GTK_WIDGET(m_window)),
> > +                            &geometry.x, &geometry.y, &geometry.width, &geometry.height, &depth);
> 
> Apparently gdk_window_get_geomtry does not include depth as a parameter in gtk+3.

I've #ifdeffed this section for GTK+ 3.x. Nice find.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.