[Webkit-unassigned] [Bug 57068] [GTK] [WebKit2] Implement a basic WebKitTestRunner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57068





--- Comment #15 from Ravi Phaneendra Kasibhatla <ravi.kasibhatla at motorola.com>  2011-04-19 23:41:49 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=89315&action=review

Looks all set for r+. Just couple of minor comments.

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h:61
> +typedef ::GModule* PlatformBundle;

Can't we define both the typedef here itself instead of 2 separate blocks?

> Tools/WebKitTestRunner/gtk/TestInvocationGtk.cpp:32
> +{

I guess the argument should be WKImageRef. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.