[Webkit-unassigned] [Bug 55053] Implement non-activating clicks to allow dragging out of a background window

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55053





--- Comment #13 from Sam Weinig <sam at webkit.org>  2011-04-12 16:33:48 PST ---
(From update of attachment 89303)
View in context: https://bugs.webkit.org/attachment.cgi?id=89303&action=review

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:297
> +bool WebPageProxy::shouldDelayWindowOrderingForEvent(const WebKit::WebMouseEvent &event)

& on the wrong side.

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:300
> +    const double MessageTimeout = 20;

The variable should not start with a capital.

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:305
> +bool WebPageProxy::acceptsFirstMouse(int eventNumber, const WebKit::WebMouseEvent &event)

Here too.

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:308
> +    const double MessageTimeout = 20;

The variable should not start with a capital.

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:673
> +void WebPage::shouldDelayWindowOrderingEvent(const WebKit::WebMouseEvent &event, bool& result)

& on the wrong side.

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:685
> +void WebPage::acceptsFirstMouse(int eventNumber, const WebKit::WebMouseEvent &event, bool& result)

Here too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.