[Webkit-unassigned] [Bug 55053] Implement non-activating clicks to allow dragging out of a background window

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55053





--- Comment #12 from Alexey Proskuryakov <ap at webkit.org>  2011-04-12 16:30:31 PST ---
(From update of attachment 89303)
View in context: https://bugs.webkit.org/attachment.cgi?id=89303&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:988
> +        return false;

This function returns a BOOL, so this should be NO, not false.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:1001
> +        return false;

Ditto.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:1009
> +        return false;

Ditto.

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:680
> +    HitTestResult hitResult = frame->eventHandler()->hitTestResultAtPoint(event.position(), YES);

This is a C++ function call, so it should use true, not YES.

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:692
> +    HitTestResult hitResult = frame->eventHandler()->hitTestResultAtPoint(event.position(), YES);

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.