[Webkit-unassigned] [Bug 58312] REGRESSION(r83561): doesn't pause in-window playback during fullscreen playback
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 12 09:40:17 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=58312
--- Comment #4 from Philippe Normand <pnormand at igalia.com> 2011-04-12 09:40:18 PST ---
(In reply to comment #2)
> (From update of attachment 89183 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89183&action=review
>
> Is it possible to include a test with this change?
>
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1714
> > if (!m_fpsSink) {
> > gst_bin_add(GST_BIN(m_videoSinkBin), m_webkitVideoSink);
> > + actualVideoSink = m_webkitVideoSink;
> > + }
> > +
>
> I think it makes sense to turn if (!m_fpsSink) into an else statement here.
Hum sorry but I don't think so, finally :)
m_fpsSink can be set to 0 in 2 cases just above this code, in the if (m_fpsSink) test.
Turning this if (!m_fpsSink) to a else would require to duplicate the code, I think.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list