[Webkit-unassigned] [Bug 58312] REGRESSION(r83561): doesn't pause in-window playback during fullscreen playback

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 12 09:33:03 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=58312





--- Comment #3 from Philippe Normand <pnormand at igalia.com>  2011-04-12 09:33:03 PST ---
(In reply to comment #2)
> (From update of attachment 89183 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89183&action=review
> 
> Is it possible to include a test with this change?
> 
> > 

I don't think this can be tested. The fact that we have 2 video-sinks is internal to the private media-player :/

Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1714
> >      if (!m_fpsSink) {
> >          gst_bin_add(GST_BIN(m_videoSinkBin), m_webkitVideoSink);
> > +        actualVideoSink = m_webkitVideoSink;
> > +    }
> > +
> 
> I think it makes sense to turn if (!m_fpsSink) into an else statement here.

OK. I can attach a new patch or do that tweak before landing if you r+ this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list