[Webkit-unassigned] [Bug 58259] Web Inspector: Enable raw HTTP headers support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58259





--- Comment #3 from Andrey Kosyakov <caseq at chromium.org>  2011-04-12 06:19:55 PST ---
(From update of attachment 89064)
View in context: https://bugs.webkit.org/attachment.cgi?id=89064&action=review

> Source/WebCore/inspector/front-end/HTTPHeadersParser.js:36
> +        if (!this._initialize(requestHeaders))

When are we supposed to hit this check (and the one in _initialize())?

> Source/WebCore/inspector/front-end/HTTPHeadersParser.js:40
> +            return null;

So we return undefined in line 37, null here -- is this the intent?

> Source/WebCore/inspector/front-end/HTTPHeadersParser.js:51
> +            console.log("Failed parsing status line from: " + this._input);

This seems to be the only line different from parseRequesHeaders(). I'd rather not copy 10 lines because of a log message -- let's just have a generic error message instead?

> Source/WebCore/inspector/front-end/Resource.js:409
> +        this._requestHeaders = null;

Why not just delete this for consistency with the rest of the code?

> Source/WebCore/inspector/front-end/ResourceHeadersView.js:327
> +            this._refreshURL();

Shouldn't we also call this._refreshFormData() here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.