[Webkit-unassigned] [Bug 58259] Web Inspector: Enable raw HTTP headers support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58259


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89064|review?                     |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2011-04-11 22:33:02 PST ---
(From update of attachment 89064)
View in context: https://bugs.webkit.org/attachment.cgi?id=89064&action=review

> LayoutTests/inspector/http-headers-parser.html:9
> +InspectorTest.createHeaders = function(lines)

just declare them as "function createHeaders()" in your "function test()"

> Source/WebCore/inspector/Inspector.json:285
> +                    "rawHeaders": { "type": "string", "optional": true, "description": "Raw HTTP response headers." },

I'd suggest renaming these to rawHttpRequest and rawHttpResponse since they contain not only headers. It might require you to rename it in multiple places.

> Source/WebCore/inspector/front-end/Resource.js:387
> +        if (!this._requestHeaders && this._rawRequestHeaders)

So we only use this parser when there are no requestHeaders? But I think we do have them at all times.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.