[Webkit-unassigned] [Bug 57068] [GTK] [WebKit2] Implement a basic WebKitTestRunner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57068





--- Comment #10 from Alejandro G. Castro <alex at igalia.com>  2011-04-12 06:03:05 PST ---
(From update of attachment 89039)

Looks good, still checking what happens and why it stalls when starting to test, but somme comments already.

View in context: https://bugs.webkit.org/attachment.cgi?id=89039&action=review

> Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp:-124
> -bool WebPage::platformCanHandleRequest(const WebCore::ResourceRequest&)
> -{
> -    // FIXME: Implement
> -    return true;
> -}
> -

Why we should remove this function?

> Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:79
> +    gint depth;
> +    gdk_window_get_geometry(gtk_widget_get_window(GTK_WIDGET(m_window)),
> +                            &geometry.x, &geometry.y, &geometry.width, &geometry.height, &depth);

Apparently gdk_window_get_geomtry does not include depth as a parameter in gtk+3.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.