[Webkit-unassigned] [Bug 57068] [GTK] [WebKit2] Implement a basic WebKitTestRunner

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 11 21:45:34 PDT 2011


--- Comment #9 from Ravi Phaneendra Kasibhatla <ravi.kasibhatla at motorola.com>  2011-04-11 21:45:34 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=88932&action=review

Great Patch :)

> Tools/WebKitTestRunner/GNUmakefile.am:24
> +	-include Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h \

Are these Prefix headers now required to be included in makefiles since we are including config.h anyways in all files as first header?

> Tools/WebKitTestRunner/GNUmakefile.am:44

Why do we require WINMM libs for GTK port?

> Tools/WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:114
> +    };

Instead of listing all fonts, can we use the env variable WEBKIT_TEST_FONTS, which is used in DRT as well as other WebKit2 ports? It simplifies the code here a lot.

> Tools/WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:35
> +static gboolean waitToDumpWatchdogTimerIntervalCallback(gpointer)

Can we name it as waitToDumpWatchdogTimerFired() itself?

> Tools/WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:38
> +    return TRUE;

Shouldn't this be FALSE? Who will cancel it since it will be firing continuously?

> Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:43
> +    gtk_widget_size_allocate(m_window, &size);

Why are we not using gtk_widget_set_size_request() since it does both window_resize & size_allocate?

> Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:60
> +


> Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp:65
> +    cancelTimeout();

Shouldn't the cancelTimeout() here based on the bool condition sent in platformRunUntil()? All other ports run until the bool goes false on which they cancel the timer. Isn't it so?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list