[Webkit-unassigned] [Bug 54634] media/video-controls-in-media-document.html has image+text diffs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54634





--- Comment #24 from Eric Carlson <eric.carlson at apple.com>  2011-04-11 13:20:55 PST ---
(From update of attachment 89057)
View in context: https://bugs.webkit.org/attachment.cgi?id=89057&action=review

> LayoutTests/media/video-controls-in-media-document.html:15
> +    var controls = layoutTestController.shadowRoot(video).firstChild.firstChild;
> +    test(controls.offsetTop < 240);
> +    layoutTestController.notifyDone();

This doesn't hard code the control height, so why use "240" for the video height? Maybe I am being pedantic because we *do* know the video dimensions, but is there any reason to not calculate the height?

Also I think it is good to structure a "test(...)" so the output shows what is being tested instead of just the result. 

For example:

    testExpected("controls.offsetTop", video.offsetHeight, "<");

will generate:

    EXPECTED (video.offsetTop < '240') OK

This can be very helpful to someone looking at a test's results later, as they don't have to view source to figure out what failed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.