[Webkit-unassigned] [Bug 54634] media/video-controls-in-media-document.html has image+text diffs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54634





--- Comment #23 from Ami Fischman <fischman at chromium.org>  2011-04-11 12:45:37 PST ---
(In reply to comment #21)
> (From update of attachment 89028 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89028&action=review
> 
> > LayoutTests/media/video-controls-in-media-document.html:15
> > +    var controls = layoutTestController.shadowRoot(video).firstChild.firstChild;
> > +    testExpected(controls.offsetTop, 208);  // == 240(video height) minus 32 (controls height).
> > +    layoutTestController.notifyDone();
> 
> Hard coding the size of the controls doesn't seem like a great idea as ports are free to use different sizes. Because this tests is to make sure controls are rendered on top of the <video> element, why not just test that the top of the controls element is above the bottom of the video element?

Done.

> 
> > LayoutTests/platform/mac/Skipped:2
> > -# Copyright (C) 2008 Apple Inc. All rights reserved.
> > +# Copyright (C) 2011 Apple Inc. All rights reserved.
> 
> An Apple notice copyright should include all years, eg. "2008, 2009, 2010, 2011".

Left alone (2008) to avoid rocking the boat (this was an auto-edit; will config emacs to leave webkit copyrights alone).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.