[Webkit-unassigned] [Bug 58115] Gather data on modal dialogs shown during unload events

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 9 00:06:54 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=58115





--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org>  2011-04-09 00:06:54 PST ---
(In reply to comment #6)
> (From update of attachment 88921 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88921&action=review
> 
> > Source/WebCore/page/Chrome.cpp:287
> > +static inline bool isDuringPageDismissal(const Frame* frame)
> > +{
> > +    return frame->loader()->pageDismissalEventBeingDispatched();
> > +}
> > +
> 
> I don't think you extract this as a function.

Meant to say "I don't think you should".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list