[Webkit-unassigned] [Bug 58115] Gather data on modal dialogs shown during unload events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58115


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88921|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2011-04-09 00:06:15 PST ---
(From update of attachment 88921)
View in context: https://bugs.webkit.org/attachment.cgi?id=88921&action=review

> Source/WebCore/page/Chrome.cpp:287
> +static inline bool isDuringPageDismissal(const Frame* frame)
> +{
> +    return frame->loader()->pageDismissalEventBeingDispatched();
> +}
> +

I don't think you extract this as a function.

> Source/WebKit/chromium/ChangeLog:10
> +        dispatched during unload events. Count the notifications through a
> +        histogram.

I don't think you need to cut off a sentence awkwardly like this since WebKit doesn't have any line limits.  You can put histogram in the previous line.

> Source/WebKit/chromium/ChangeLog:13
> +        No tests because it's not clear how to test chromium histograms from
> +        webkit.

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.