[Webkit-unassigned] [Bug 57717] Convert use of raw pointers to RefPtr in using Cairo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 8 10:55:37 PDT 2011


--- Comment #18 from Joone Hur <joone.hur at collabora.co.uk>  2011-04-08 10:55:37 PST ---
(In reply to comment #17)
> (From update of attachment 88561 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88561&action=review
> >>> Source/WebCore/platform/graphics/cairo/FontCairo.cpp:95
> >>>          shadow->endShadowLayer(graphicsContext);
> >> 
> >> I don't think you should use RefPtr here since you don't want to take a reference.
> > 
> > However, beginShadowLayer returns RefPtr<cairo_t>, so I need to use RefPtr here.
> Typically things only return a PassRefPtr if they are handing off ownership. It seems that beginShadowLayer shouldn't make this suggestion.

Yes, we can't use a PassRefPtr as return value here, so it seems to make sense to just leave m_layerContext as a cairo_t to return a raw pointer.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list