[Webkit-unassigned] [Bug 57717] Convert use of raw pointers to RefPtr in using Cairo

Mon Apr 11 13:07:01 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=57717

--- Comment #19 from Brent Fulgham <bfulgham at webkit.org>  2011-04-11 13:07:01 PST ---
(From update of attachment 88561)
View in context: https://bugs.webkit.org/attachment.cgi?id=88561&action=review

>>> Source/WebCore/platform/graphics/cairo/CairoPath.h:34
>>> +        static RefPtr<cairo_surface_t> pathSurface = adoptRef(cairo_image_surface_create(CAIRO_FORMAT_A8, 1, 1));
>> 
>> Ack! I didn't realize this was static. Please revert this line. Sorry!
> 
> That's ok.

Is this static really threadsafe? Under MSVCRT (which also uses this code) there is no guarantee that this will only execute once.  Could it be changed to a static initializer so that it is known to complete prior to multi-threaded execution?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.