[Webkit-unassigned] [Bug 58040] [GTK] Unskip accessibility/input-slider.html and accessibility/media-element.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58040





--- Comment #3 from Mario Sanchez Prada <msanchez at igalia.com>  2011-04-08 09:31:13 PST ---
(In reply to comment #2)
> (From update of attachment 88627 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88627&action=review
> 
> r=me. I suspect you'd rather call accessibilityIsIgnored() than accessibilityPlatformIncludesObject() which i think should really only be called by accessibilityIsIgnored() itself
> 
> > Source/WebCore/accessibility/AccessibilitySlider.cpp:99
> > +    if (thumb->accessibilityPlatformIncludesObject() == IgnoreObject)
> 
> can you just ask accessibilityIsIgnored() here.

Problem is that currently accessibilityIsIgnored() is a private method for AXSliderThumb which always return 'false' and, even if I could change that implementation to call accessibilityIsIgnoredBase(), AXSliderThumb is a subclass of AXObject (not AXRenderObject), where that function is not defined either (accessibilityIsIgnoredBase is defined for AXRenderObject)... 

So that's why I directly called accessibilityPlatformIncludesObject() instead, following the lead of AccessibilityMenuList::addChildren().

However, I think I could slightly change my patch to:

  1. Implement accessibilityIsIgnored() in AXSliderThumb and make it public (so I can call it from AXSlider:addChildren())
  2. Make AXSliderThumb::accessibilityIsIgnored() call accessibilityPlatformIncludesObject() from there, which is defined for AXObject.

I'll make that change and propose a new patch then...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.