[Webkit-unassigned] [Bug 58040] [GTK] Unskip accessibility/input-slider.html and accessibility/media-element.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 8 08:27:03 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=58040


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88627|review?                     |review+
               Flag|                            |




--- Comment #2 from chris fleizach <cfleizach at apple.com>  2011-04-08 08:27:03 PST ---
(From update of attachment 88627)
View in context: https://bugs.webkit.org/attachment.cgi?id=88627&action=review

r=me. I suspect you'd rather call accessibilityIsIgnored() than accessibilityPlatformIncludesObject() which i think should really only be called by accessibilityIsIgnored() itself

> Source/WebCore/accessibility/AccessibilitySlider.cpp:99
> +    if (thumb->accessibilityPlatformIncludesObject() == IgnoreObject)

can you just ask accessibilityIsIgnored() here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list