[Webkit-unassigned] [Bug 58033] [GStreamer] report playback statistics

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58033





--- Comment #5 from Philippe Normand <pnormand at igalia.com>  2011-04-08 01:26:15 PST ---
(In reply to comment #4)
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1677
> > +        // The verbose property has been added in -bad 0.10.22. Making
> > +        // this whole code depend on it because we don't want
> > +        // fpsdiplaysink to spit data on stdout.
> > +        GstElementFactory* factory = GST_ELEMENT_FACTORY(GST_ELEMENT_GET_CLASS(m_fpsSink)->elementfactory);
> > +        if (gst_plugin_feature_check_version(GST_PLUGIN_FEATURE(factory), 0, 10, 22)) {
> > +            g_object_set(m_fpsSink, "verbose", FALSE , NULL);
> 
> Will this affect the required gstreamer version since the property only exists >= 0.10.22?
> 

We don't depend on specific -bad version. Actually we don't even check for its presence at configure time.

If a suitable -bad version is not available at runtime the dropped/rendered frame counters will always remain at 0.

BTW we depend on this fpsdisplaysink patch: https://bugzilla.gnome.org/show_bug.cgi?id=647030

It'd be wise to wait it to be commited before pushing this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.