[Webkit-unassigned] [Bug 58033] [GStreamer] report playback statistics

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58033





--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2011-04-07 17:05:12 PST ---
(From update of attachment 88623)
View in context: https://bugs.webkit.org/attachment.cgi?id=88623&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1003
> +    gst_object_replace((GstObject**) &m_webkitAudioSink, (GstObject*) element.get());

Please use a C++ style cast here.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1677
> +        // The verbose property has been added in -bad 0.10.22. Making
> +        // this whole code depend on it because we don't want
> +        // fpsdiplaysink to spit data on stdout.
> +        GstElementFactory* factory = GST_ELEMENT_FACTORY(GST_ELEMENT_GET_CLASS(m_fpsSink)->elementfactory);
> +        if (gst_plugin_feature_check_version(GST_PLUGIN_FEATURE(factory), 0, 10, 22)) {
> +            g_object_set(m_fpsSink, "verbose", FALSE , NULL);

Will this affect the required gstreamer version since the property only exists >= 0.10.22?

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1679
> +            // turn off text overlay unless logging is enabled.

turn => Turn

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.