[Webkit-unassigned] [Bug 57998] webkit-patch should have a download-attachments command

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 6 16:39:04 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=57998





--- Comment #1 from Darin Adler <darin at apple.com>  2011-04-06 16:39:03 PST ---
Interesting. I can’t remember asking for it, but it does fit in pretty well with how I used to do things. It’s especially useful if I have a patch that I want to refactor into two patches in my primitive non-git way.

Your naming scheme seems good except for the $ATTACHMENT_DESCRIPTION part. Often the attachments all have the description “Patch” or long descriptions that wouldn’t work too well as file names.

Maybe bug-$NUMBER-$ATTACHMENT_INDEX.patch where the index is 2 for the second attachment on a given bug, 3 for the third attachment, and omitted entirely if there is only a single attachment. Or we could use a patch index that only counts patch attachments and doesn’t count others (test cases and the like).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list