[Webkit-unassigned] [Bug 52148] [Gtk] Implement support for Embedded Objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52148


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85344|0                           |1
        is obsolete|                            |
  Attachment #85344|review?                     |
               Flag|                            |
  Attachment #88447|                            |review?
               Flag|                            |




--- Comment #10 from Mario Sanchez Prada <msanchez at igalia.com>  2011-04-06 09:33:23 PST ---
Created an attachment (id=88447)
 --> (https://bugs.webkit.org/attachment.cgi?id=88447&action=review)
Patch proposal + Unit test

Attaching a new patch with some changes over it, based on Chris's previous comments.

(In reply to comment #9)
> [...]
> > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1156
> > > +#endif
> > 
> > Seems like we should have a method like textIteratorBehavior() that will
> > consolidate this logic
> 
> Ok.

Done.

> > > Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:2408
> > > +
> > 
> > Instead of referencing AccessibilityRenderObject in platform code, which i 
> > don't like, I think we should either have a method renderer() on 
> > AccessibilityObject or isRendererReplaced() on accessibility object.
> 
> Ok, but as AccessibilityRenderObject is also being referenced in several
> other parts of the GTK's wrapper, I wonder whether this change shouldn't
> go in a separate patch to this one, and now focus in fixing this bug.

Done, by reporting a new bug (bug 57955) for fixing that, providing a patch there (currently pending on review) and developing the new patch for this bug on top of that one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.