[Webkit-unassigned] [Bug 52148] [Gtk] Implement support for Embedded Objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52148


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |enrica at apple.com




--- Comment #9 from Mario Sanchez Prada <msanchez at igalia.com>  2011-04-06 07:45:43 PST ---
(In reply to comment #8)
> (From update of attachment 85344 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85344&action=review
> 
> Accessibility changes generally look pretty good. You should get someone else 
> to take a look at the text iterator changes to make sure something isn't 
> being missed. Accessibility side (modulus changes) have my review

Thanks. Adding Enrica Casucci to CC, as the person that already took a look into other patches I wrote in the past, related to text editing.

> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1156
> > +#endif
> 
> Seems like we should have a method like textIteratorBehavior() that will
> consolidate this logic

Ok.

> > Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:2408
> > +
> 
> Instead of referencing AccessibilityRenderObject in platform code, which i 
> don't like, I think we should either have a method renderer() on 
> AccessibilityObject or isRendererReplaced() on accessibility object.

Ok, but as AccessibilityRenderObject is also being referenced in several other parts of the GTK's wrapper, I wonder whether this change shouldn't go in a separate patch to this one, and now focus in fixing this bug.

What do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.