[Webkit-unassigned] [Bug 57921] Move the MouseEventWithHitTestResults::targetNode() method on to EventHandler.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57921





--- Comment #3 from Alice Boxhall <aboxhall at chromium.org>  2011-04-05 23:35:02 PST ---
(In reply to comment #2)
> (From update of attachment 88370 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88370&action=review
> 
> Ugh... so each port implements a part of EventHandler?   That's so ugly.  We'd definitely need to do a lot of refactoring here.  r=me provided you revert the change to make subframeForHitTestResult a member of EventHandler or explain why that's needed.
> 
> > Source/WebCore/page/EventHandler.cpp:1099
> > -Frame* subframeForHitTestResult(const MouseEventWithHitTestResults& hitTestResult)
> > +Frame* EventHandler::subframeForHitTestResult(const MouseEventWithHitTestResults& hitTestResult)
> 
> Why does this function need to be a member of EventHandler?

So that it can access the private member targetNode() function.

> > Source/WebCore/page/EventHandler.h:271
> > +    static Frame* subframeForHitTestResult(const MouseEventWithHitTestResults&);
> 
> Again, I don't think this function needs to be a member function.

As above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.