[Webkit-unassigned] [Bug 57921] Move the MouseEventWithHitTestResults::targetNode() method on to EventHandler.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 5 23:33:32 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #88370|review?                     |review+
               Flag|                            |

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org>  2011-04-05 23:33:32 PST ---
(From update of attachment 88370)
View in context: https://bugs.webkit.org/attachment.cgi?id=88370&action=review

Ugh... so each port implements a part of EventHandler?   That's so ugly.  We'd definitely need to do a lot of refactoring here.  r=me provided you revert the change to make subframeForHitTestResult a member of EventHandler or explain why that's needed.

> Source/WebCore/page/EventHandler.cpp:1099
> -Frame* subframeForHitTestResult(const MouseEventWithHitTestResults& hitTestResult)
> +Frame* EventHandler::subframeForHitTestResult(const MouseEventWithHitTestResults& hitTestResult)

Why does this function need to be a member of EventHandler?

> Source/WebCore/page/EventHandler.h:271
> +    static Frame* subframeForHitTestResult(const MouseEventWithHitTestResults&);

Again, I don't think this function needs to be a member function.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list