[Webkit-unassigned] [Bug 52148] [Gtk] Implement support for Embedded Objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52148





--- Comment #8 from chris fleizach <cfleizach at apple.com>  2011-04-05 19:23:18 PST ---
(From update of attachment 85344)
View in context: https://bugs.webkit.org/attachment.cgi?id=85344&action=review

Accessibility changes generally look pretty good. You should get someone else to take a look at the text iterator changes to make sure something isn't being missed. Accessibility side (modulus changes) have my review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1156
> +#endif

Seems like we should have a method like textIteratorBehavior() that will consolidate this logic

> Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:2408
> +

Instead of referencing AccessibilityRenderObject in platform code, which i don't like, I think we should either have a method renderer() on AccessibilityObject or isRendererReplaced() on accessibility object.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.