[Webkit-unassigned] [Bug 57796] [Qt] [WK2] Allow WK2 ENABLE_NETSCAPE_PLUGIN_API=0 to work in non-X11 unix environments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57796





--- Comment #3 from Keith Kyzivat <keith.kyzivat at nokia.com>  2011-04-05 09:28:16 PST ---
(From update of attachment 88152)
View in context: https://bugs.webkit.org/attachment.cgi?id=88152&action=review

What I've come across is - I have a Linux install that contains Qt (Lighthouse), but no X11.  The WK2 NPAPI code currently has dependencies on X11, so I'd like to be able to disable it. 
It appears that WK2 does not honor ENABLE_NETSCAPE_PLUGIN_API=0, so I put this in here as an easy way to make this particular case work.

Right now, the only files that use PLUGIN_ARCHITECTURE_XXX are all relating to NPAPI (that I can see).
I do see what you're saying though - that "PLUGIN_ARCHITECTURE_" indicates this applies to more than just NPAPI.

Maybe the answer is an ENABLE_PLUGIN_ARCHITECTURE=0 define?

>> Tools/Tools.pro:14
>> +        exists($$PWD/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro): SUBDIRS += DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro
> 
> Why do you change the indentation?

This is leftover from a prior iteration, and I missed cleaning it up.  Will fix in an updated patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.