[Webkit-unassigned] [Bug 57796] [Qt] [WK2] Allow WK2 ENABLE_NETSCAPE_PLUGIN_API=0 to work in non-X11 unix environments

Tue Apr 5 05:03:23 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=57796

Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88152|review?                     |review-
               Flag|                            |

--- Comment #2 from Benjamin Poulain <benjamin at webkit.org>  2011-04-05 05:03:23 PST ---
(From update of attachment 88152)
View in context: https://bugs.webkit.org/attachment.cgi?id=88152&action=review

Why the guard #elif (PLATFORM(QT) || (PLATFORM(GTK))) && (OS(UNIX) && !OS(MAC_OS_X)) is not enough for your issue?
Your fix looks weird to me, the plugin architecture seems more general than just NPAPI.

> Tools/Tools.pro:14
> +        exists($$PWD/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro): SUBDIRS += DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro

Why do you change the indentation?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.