[Webkit-unassigned] [Bug 43903] Speeding up SVG filters with multicore (SMP) support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43903





--- Comment #29 from Gabor Loki <loki at webkit.org>  2011-04-05 06:26:21 PST ---
> On the whole looks good to me, but please fix the following things:
> 
> - I agree with Zoltan ( https://bugs.webkit.org/show_bug.cgi?id=43903#c16 ), we need 
> template for parameter passing to avoid ugly reinterpret_casts and using sizof.

Well, it seems an easy task, but the ParallelJobs has a static s_threadPool member in case of using WebKit's threading. If ParallelJobs is changed to template<typename Type>ParallelJobs, we will end up in more s_threadPool members (one for each different template type). This is not what we want, we should have only one thread pool. A possible solution is to create a base class (for example ParallelEnvironment) which contains the s_threadPool member and the related ThreadPrivate class.

I am still not convinced which solution is better - a template class with a base pool, or passing the size of the parameter.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.