[Webkit-unassigned] [Bug 43903] Speeding up SVG filters with multicore (SMP) support
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 4 08:51:24 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=43903
Csaba Osztrogonac <ossy at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #83307|review? |review-
Flag| |
--- Comment #28 from Csaba Osztrogonac <ossy at webkit.org> 2011-04-04 08:51:22 PST ---
(From update of attachment 83307)
View in context: https://bugs.webkit.org/attachment.cgi?id=83307&action=review
On the whole looks good to me, but please fix the following things:
- I agree with Zoltan ( https://bugs.webkit.org/show_bug.cgi?id=43903#c16 ), we need
template for parameter passing to avoid ugly reinterpret_casts and using sizof.
- Please fix the typo detected by smfr. (s/Simmetric/Symmetric)
- And what about the other build systems? You should add the new files
for all build system. ( Or at least disable PARALLEL_JOBS if !PLATFORM(QT) )
For example it doesn't build on Windows because of missing include path.
r- for the present due to my comments above and below.
> Source/JavaScriptCore/wtf/ParallelJobs.cpp:135
> + ASSERT(m_numberOfJobs > 0);
m_numberOfJobs is always greater than 0 if !ENABLE(OPENMP)
> Source/JavaScriptCore/wtf/ParallelJobs.h:44
> +// ParallelJobs parallelJobs(&worker, sizeof(Parameters));
s/worker/workerFunction
> Source/JavaScriptCore/wtf/Platform.h:1162
> +#if !defined(ENABLE_PARALLEL_JOBS) && ENABLE(OPENMP)
> +#define ENABLE_PARALLEL_JOBS 1
> +#endif
We shouldn't enable parallel jobs if ENABLE(SINGLE_THREADED) is
true, so we need an additional !ENABLE(SINGLE_THREADED) guard.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list