[Webkit-unassigned] [Bug 57617] [Qt][WK2] Implement PLUGIN_PROCESS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57617





--- Comment #4 from Balazs Kelemen <kbalazs at webkit.org>  2011-04-01 07:41:31 PST ---
(In reply to comment #3)
> (From update of attachment 87853 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=87853&action=review
> 
> > Source/WebKit2/PluginProcess/PluginProcess.cpp:160
> > +#elif PLATFORM(QT)
> > +    int sockets[2];
> > +    if (socketpair(AF_UNIX, SOCK_DGRAM, 0, sockets) == -1) {
> > +        qDebug() << "Creation of socket failed with errno:" << errno;
> 
> Wouldn't this work for any UNIX? What about making a PluginProcessUNIX instead?

Definitely this patch should not be Qt-only. Furthermore I would like
a change that replacing the "PLATFORM(QT) || PLATFORM(GTK)" conditions in IPC
code with smg new macro flag (UNIX_IPC is my candidate). This should be handled
first (maybe in #49791?). I just uploaded this patch now for feedback.

> 
> > Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:92
> > +                                 "QtWebProcess" : "QtPluginProcess");
> 
> I think that should be called QtWebPluginProcess not just plugin process.

Yep.

> 
> > Source/WebKit2/qt/EnvHttpProxyFactory.h:34
> > +#include <QList>
> > +#include <QNetworkProxyFactory>
> > +
> > +namespace WebKit {
> > +
> > +class EnvHttpProxyFactory : public QNetworkProxyFactory {
> > +public:
> > +    static void initializeProxy();
> 
> I would have done this splitting out as a separate patch

Ok.

> 
> > Source/WebKit2/qt/PluginMainQt.cpp:3
> > + * Copyright (C) 2011 University of Szeged
> 
> Don't you want a dot at the end?

Yep.

I will return to this after the UNIX_IPC thing will be done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.