[Webkit-unassigned] [Bug 57617] [Qt][WK2] Implement PLUGIN_PROCESS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57617





--- Comment #3 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-04-01 06:56:07 PST ---
(From update of attachment 87853)
View in context: https://bugs.webkit.org/attachment.cgi?id=87853&action=review

> Source/WebKit2/PluginProcess/PluginProcess.cpp:160
> +#elif PLATFORM(QT)
> +    int sockets[2];
> +    if (socketpair(AF_UNIX, SOCK_DGRAM, 0, sockets) == -1) {
> +        qDebug() << "Creation of socket failed with errno:" << errno;

Wouldn't this work for any UNIX? What about making a PluginProcessUNIX instead?

> Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:92
> +                                 "QtWebProcess" : "QtPluginProcess");

I think that should be called QtWebPluginProcess not just plugin process.

> Source/WebKit2/qt/EnvHttpProxyFactory.h:34
> +#include <QList>
> +#include <QNetworkProxyFactory>
> +
> +namespace WebKit {
> +
> +class EnvHttpProxyFactory : public QNetworkProxyFactory {
> +public:
> +    static void initializeProxy();

I would have done this splitting out as a separate patch

> Source/WebKit2/qt/PluginMainQt.cpp:3
> + * Copyright (C) 2011 University of Szeged

Don't you want a dot at the end?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.