[Webkit-unassigned] [Bug 46624] Web Inspector: implement pausing on event listeners (back-end part)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46624





--- Comment #7 from Pavel Podivilov <podivilov at chromium.org>  2010-09-30 09:40:52 PST ---
(In reply to comment #6)
> (From update of attachment 69336 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69336&action=review
> 
> > WebCore/inspector/InspectorDebuggerAgent.cpp:-319
> > -    if (!s_debuggerAgentOnBreakpoint)
> 
> Why are you deleting this code?
This code was used to prevent accessing InspectorDebuggerAgent fields if the object was deleted. I've moved the code to didContinue method which is called only if InspectorDebuggerAgent was not deleted.

> 
> > WebCore/inspector/InspectorDebuggerAgent.h:70
> > +    void schedulePauseOnNextStatement(DebuggerEventType type, PassRefPtr<InspectorValue> data);
> 
> setPauseOnNextStatement?
schedulePauseOnNextStatement and cancelPauseOnNextStatement have different signatures, so we can't make a single method. And schedulePauseOnNextStatement alone doesn't look like a setter.

> 
> > WebCore/inspector/InspectorInstrumentation.cpp:159
> > +    timelineAgentsStack().append(std::make_pair(s_callDepth, 0));
> 
> Looks like too much code... Will we need to do it for every will/did pair?
Yep, we don't actually need this code here. I'll move it below the frontend and timelineAgent checks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.