[Webkit-unassigned] [Bug 46624] Web Inspector: implement pausing on event listeners (back-end part)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46624


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69336|review?                     |
               Flag|                            |




--- Comment #6 from Pavel Feldman <pfeldman at chromium.org>  2010-09-30 09:10:42 PST ---
(From update of attachment 69336)
View in context: https://bugs.webkit.org/attachment.cgi?id=69336&action=review

> WebCore/inspector/InspectorDebuggerAgent.cpp:-319
> -    if (!s_debuggerAgentOnBreakpoint)

Why are you deleting this code?

> WebCore/inspector/InspectorDebuggerAgent.h:70
> +    void schedulePauseOnNextStatement(DebuggerEventType type, PassRefPtr<InspectorValue> data);

setPauseOnNextStatement?

> WebCore/inspector/InspectorInstrumentation.cpp:159
> +    timelineAgentsStack().append(std::make_pair(s_callDepth, 0));

Looks like too much code... Will we need to do it for every will/did pair?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.