[Webkit-unassigned] [Bug 46524] Bridge all FileSystem operations on Workers to the MainThread

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46524





--- Comment #8 from Kinuko Yasuda <kinuko at chromium.org>  2010-09-27 17:09:28 PST ---
(In reply to comment #7)
> (From update of attachment 68811 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68811&action=review
> 
> Please consider doing Adam's comment and mine.
> 
> Thanks!
> 
> > WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp:150
> > +PassRefPtr<WorkerFileSystemCallbacksBridge> WorkerFileSystemCallbacksBridge::createForOpenFileSystem(WebWorkerBase* worker, ScriptExecutionContext* workerContext, WebFileSystemCallbacks* callbacks, WebCommonWorkerClient* commonClient, WebFileSystem::Type type, long long size, const String& mode)
> 
> I wouldn't bother making these be "createFor" methods and returning a class that no one ever uses.
> 
> Consider just returning void and calling the method: "WorkerFileSystemCallbacksBridge::openFileSystem".

Thanks for reviewing!  I'm planning to store the returned value to a local variable in synchronous cases (in a coming change set) while waiting for completion, so I'll leave it as is in this patch.  (Will make it return void if it turns out I won't use it.)

Will definitely fix the 'explicit' one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.