[Webkit-unassigned] [Bug 46524] Bridge all FileSystem operations on Workers to the MainThread

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46524


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68811|review?                     |review+
               Flag|                            |




--- Comment #7 from David Levin <levin at chromium.org>  2010-09-27 16:40:10 PST ---
(From update of attachment 68811)
View in context: https://bugs.webkit.org/attachment.cgi?id=68811&action=review

Please consider doing Adam's comment and mine.

Thanks!

> WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp:150
> +PassRefPtr<WorkerFileSystemCallbacksBridge> WorkerFileSystemCallbacksBridge::createForOpenFileSystem(WebWorkerBase* worker, ScriptExecutionContext* workerContext, WebFileSystemCallbacks* callbacks, WebCommonWorkerClient* commonClient, WebFileSystem::Type type, long long size, const String& mode)

I wouldn't bother making these be "createFor" methods and returning a class that no one ever uses.

Consider just returning void and calling the method: "WorkerFileSystemCallbacksBridge::openFileSystem".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.