[Webkit-unassigned] [Bug 46613] [EFL] remove strdup in ewk_setting.cpp using eina_stringshare

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46613





--- Comment #4 from Ryuan Choi <ryuan.choi at samsung.com>  2010-09-27 08:51:25 PST ---
(In reply to comment #3)
> (From update of attachment 68891 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68891&action=review
> 
> > WebKit/efl/ChangeLog:8
> > +        Add variables shared by eins_stringshare and remove strdup.
> 
> typo here
> 
> > WebKit/efl/ewk/ewk_settings.cpp:85
> > + * @return database path or NULL if none or web database is not supported.
> 
> You are not mentioning in documentation that this is stringshared and user should not free it, but instead using eina_stringshare functions. Look at ewk_* APIs that return stringshared chars and let a doc similar to that.

Thanks, I'll fix it as you mentioned.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.