[Webkit-unassigned] [Bug 46613] [EFL] remove strdup in ewk_setting.cpp using eina_stringshare

Mon Sep 27 07:58:39 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=46613

Lucas De Marchi <demarchi at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68891|commit-queue?               |commit-queue-
               Flag|                            |

--- Comment #3 from Lucas De Marchi <demarchi at webkit.org>  2010-09-27 07:58:39 PST ---
(From update of attachment 68891)
View in context: https://bugs.webkit.org/attachment.cgi?id=68891&action=review

> WebKit/efl/ChangeLog:8
> +        Add variables shared by eins_stringshare and remove strdup.

typo here

> WebKit/efl/ewk/ewk_settings.cpp:85
> + * @return database path or NULL if none or web database is not supported.

You are not mentioning in documentation that this is stringshared and user should not free it, but instead using eina_stringshare functions. Look at ewk_* APIs that return stringshared chars and let a doc similar to that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.