[Webkit-unassigned] [Bug 46029] [EFL] add pango support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46029





--- Comment #3 from Ryuan Choi <ryuan.choi at samsung.com>  2010-09-25 23:45:02 PST ---
(In reply to comment #2)
> Hi Ryuan,
> 
> Do you really need to include the gtk directory here?
> 
> +IF (WTF_USE_PANGO)
> +  LIST(APPEND WebKit_INCLUDE_DIRECTORIES
> +    "${WEBCORE_DIR}/platform/graphics/gtk"
> +    ${Pango_INCLUDE_DIRS}
> +  )
> +  LIST(APPEND WebKit_LIBRARIES
> +    ${Pango_LIBRARIES}
> 

sorry about late answer.
now, Pango related implementation was in platform/graphics/gtk.
unless moving it, we should include it.

> And maybe you should also remove FIND_PACKAGE(Freetype) from the global scope and just use it when using that backend. Or is it necessary by pango too?
> 
> Other than that, the patch seems nice.

It's my mistake. I'll move it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.