[Webkit-unassigned] [Bug 46029] [EFL] add pango support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46029


Rafael Antognolli <antognolli at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |antognolli at profusion.mobi




--- Comment #2 from Rafael Antognolli <antognolli at profusion.mobi>  2010-09-20 11:28:03 PST ---
Hi Ryuan,

Do you really need to include the gtk directory here?

+IF (WTF_USE_PANGO)
+  LIST(APPEND WebKit_INCLUDE_DIRECTORIES
+    "${WEBCORE_DIR}/platform/graphics/gtk"
+    ${Pango_INCLUDE_DIRS}
+  )
+  LIST(APPEND WebKit_LIBRARIES
+    ${Pango_LIBRARIES}

And maybe you should also remove FIND_PACKAGE(Freetype) from the global scope and just use it when using that backend. Or is it necessary by pango too?

Other than that, the patch seems nice.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.