[Webkit-unassigned] [Bug 45599] [Cairo] Generalize ContextShadow from the Qt port and use it for shadow code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45599


Ariya Hidayat <ariya.hidayat at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68401|review?                     |review+
               Flag|                            |




--- Comment #15 from Ariya Hidayat <ariya.hidayat at gmail.com>  2010-09-22 22:26:17 PST ---
(From update of attachment 68401)
View in context: https://bugs.webkit.org/attachment.cgi?id=68401&action=review

Nice stuff :)

> WebCore/platform/graphics/ContextShadow.h:113
> +    void calculateMinimalLayerRect(const FloatRect& layerArea, const IntRect& clipRect);

I guess 'calculateLayerBoundingRect' is less complicated. 'Minimal' there does not add anything.


Otherwise, LGTM.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.