[Webkit-unassigned] [Bug 45599] [Cairo] Generalize ContextShadow from the Qt port and use it for shadow code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45599





--- Comment #14 from Martin Robinson <mrobinson at webkit.org>  2010-09-22 11:29:35 PST ---
(In reply to comment #12)

Thanks for the review!

> > WebCore/platform/graphics/ContextShadow.cpp:33
> > +#include "MathExtras.h"
> > +#include "Timer.h"
> shouldn'T it be <wtf/MathExtras.h>? not sure about timer. Why do you need timer?

Fixed! Also removed the extra Timer.h.

> > WebCore/platform/graphics/ContextShadow.cpp:57
> > -    if (!color.isValid() || !color.alpha()) {
> > +    if (!m_color.isValid()) {
> Why not chechink for alpha?

I'm not sure where that went. I added it back.

> > WebCore/platform/graphics/ContextShadow.cpp:76
> > +    m_offset = FloatSize(0, 0);
> Just FloatSize()

Fixed!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.