[Webkit-unassigned] [Bug 46086] Web Inspector: implement pausing on XHR

Wed Sep 22 08:46:56 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=46086

Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68362|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |

--- Comment #14 from Pavel Feldman <pfeldman at chromium.org>  2010-09-22 08:46:56 PST ---
(From update of attachment 68362)
View in context: https://bugs.webkit.org/attachment.cgi?id=68362&action=review

> WebCore/inspector/InspectorController.cpp:156
> +unsigned InspectorController::s_inspectorControllerCount = 0;

I don't see it incrementing.

> WebCore/inspector/InspectorController.cpp:1683
> +        RefPtr<InspectorObject> condition = breakpoint->getObject("condition");

Nit: condition should be optional.

> WebCore/inspector/InspectorController.cpp:1687
> +        if (!condition->getString("url", &url))

Same here, just stop on any.

> WebCore/inspector/InspectorController.h:492
> +inline InspectorController* InspectorController::inspectorControllerForDocument(Document* document)

It is worth checking counter here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.