[Webkit-unassigned] [Bug 46086] Web Inspector: implement pausing on XHR

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46086





--- Comment #13 from Pavel Podivilov <podivilov at chromium.org>  2010-09-22 06:17:40 PST ---
(In reply to comment #11)
> (From update of attachment 68359 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68359&action=review
> 
> > WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp:117
> > +    InspectorController::instrumentWillSendXMLHttpRequest(xmlHttpRequest->scriptExecutionContext(), xmlHttpRequest->url());
> 
> Please guard this with #ifdef
With disabled inspector controller, this function wouldn't be called.

> 
> > WebCore/inspector/Inspector.idl:140
> > +        [handler=Controller] void setNativeBreakpoint(in unsigned int type, in Object breakpoint, out unsigned int breakpointId);
> 
> It is unclear how to specify 'breakpoint' parameter format. Why does it have url property? Should we merge 'type' into 'breakpoint' instead? Like
> 
> breakpoint: { type: "XHR", condition: { url : "foo" } }
done

> 
> > WebCore/inspector/InspectorController.h:492
> > +    ASSERT(document);
> 
> Counter?
done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.