[Webkit-unassigned] [Bug 46165] Focused frame information needed in Chrome and ChromeClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46165





--- Comment #7 from Juha Savolainen <juha.savolainen at weego.fi>  2010-09-22 08:36:38 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #3)
> > > (From update of attachment 68192 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=68192&action=review
> > > 
> > > > WebCore/page/ChromeClient.h:90
> > > > +        virtual void focusedFrameChanged() {};
> > > 
> > > I would prefer if this was pure-virtual like most of the others in this file.
> > 
> > Pure virtual means that it must be implemented in derived class and I thought that we need this method only in WebKit2-side. If this is changed to pure virtual method then it must be added to all ChromeClients. And implementation would be empty.
> 
> Yes. That is the normal way we do things.

Ok, if that is rule then it should fix to pure virtual altought I have a little bit different opinion.

> I am still not clear on why the user needs to know the name of the focused frame?  What can they do with that information?

Sorry, my mistake. I meaned focused frame url.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.