[Webkit-unassigned] [Bug 46165] Focused frame information needed in Chrome and ChromeClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46165





--- Comment #6 from Sam Weinig <sam at webkit.org>  2010-09-22 06:25:24 PST ---
(In reply to comment #5)
> (In reply to comment #3)
> > (From update of attachment 68192 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=68192&action=review
> > 
> > > WebCore/page/ChromeClient.h:90
> > > +        virtual void focusedFrameChanged() {};
> > 
> > I would prefer if this was pure-virtual like most of the others in this file.
> 
> Pure virtual means that it must be implemented in derived class and I thought that we need this method only in WebKit2-side. If this is changed to pure virtual method then it must be added to all ChromeClients. And implementation would be empty.

Yes. That is the normal way we do things.

> 
> > Can you also explain the use case a little more about the use case for having this information in the UIProcess. Why is it necessary to know which frame has focus?
> 
> Yes, sure.
> Main point is that this is needed because I have done QWKFrame API(initial version, just 5 method) to WebKit2 which is similar than QWebFrame API. The rest patches will come later.
> 
> I will add a new class, QWKFrame which have eg. frameName-method which returns frame name. 
> The use case: user wants to know name of the current frame(=focused frame), currently WebKit2 C-API dosen't support any other than mainframe. If we don't do this notification, then we must do synchronized call from UIProcess to WebProcess everytime when someone wants access to frames. I think we should send frameID to UIProcess when it's changed so it will be there allready.

I am still not clear on why the user needs to know the name of the focused frame?  What can they do with that information?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.