[Webkit-unassigned] [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25898


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68346|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #91 from Martin Robinson <mrobinson at webkit.org>  2010-09-22 07:10:00 PST ---
(From update of attachment 68346)
View in context: https://bugs.webkit.org/attachment.cgi?id=68346&action=review

On further consideration, I'm pretty nervous that this does not hava test attached to it? Is it possible to write one?

> WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:73
> +    GOwnPtr<gchar> detail;
> +    switch (textChange) {
> +    case AXObjectCache::AXTextInserted:
> +        detail.set(g_strdup("text-changed::insert"));
> +        break;
> +    case AXObjectCache::AXTextDeleted:
> +        detail.set(g_strdup("text-changed::delete"));
> +        break;
> +    }

Please use CString here. Sorry I didn't notice this before.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.