[Webkit-unassigned] [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25898


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68263|0                           |1
        is obsolete|                            |
  Attachment #68346|                            |review?, commit-queue?
               Flag|                            |




--- Comment #90 from Mario Sanchez Prada <msanchez at igalia.com>  2010-09-22 01:05:09 PST ---
Created an attachment (id=68346)
 --> (https://bugs.webkit.org/attachment.cgi?id=68346)
Single patch for fixing this bug

(In reply to comment #89)
> (In reply to comment #88)
> 
> AccessibilityRenderObject.cpp is not exported as a header, and I don't think it should be.
> 
> Really, anyone using Accessibility in WebKit, should only know about AXObjectCache and AccessibilityObject.

That makes sense, and now that I look in AXObjectCache.h, I see the new functions I'm adding there are the only ones requiring AccessibilityRenderObject's as parameters, instead of just AccessibilityObject's.

Hence, attaching a new patch (hope this is the last strike!) where I changed the type of those parameters, letting the platform specific code to do the additional checks to make sure an AccessibilityRenderObject is being passed to nodeTextChangePlatformNotification in the case of GTK.

Sorry for so much hassle with this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.